fix(share/eds): scale up inverted_index badger levels #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walldiss
requested review from
renaynay,
Wondertan,
vgonkivs and
distractedm1nd
as code owners
|
Why not 9 or 10? |
|
Can this be re-configured or would it be breaking? |
vgonkivs
approved these changes
Aug 22, 2023
|
9 levels is harder for compaction there is reasonable doubts we would reach 11TB inverted index size before getting rid of it |
It is not breaking, but could cause node to do long compaction while preventing all store related operation. Compaction could take 1-2 hours on badger size of 1.1 TB. Should be less for smaller sizes, but I don't have exact numbers. |
renaynay
approved these changes
Aug 22, 2023
Wondertan
approved these changes
Aug 22, 2023
renaynay
pushed a commit
to renaynay/celestia-node
that referenced
this pull request
Aug 23, 2023
Current instance of badger uses default value (7) for amount of used levels, that allows badger to grow up to 1.1TiB. This limit could be reaching within 1 week of 128 ods size blocks, so we need to bump the value to at least 8 levels (11 TiB).
walldiss
added a commit
that referenced
this pull request
Sep 22, 2023
Current instance of badger uses default value (7) for amount of used levels, that allows badger to grow up to 1.1TiB. This limit could be reaching within 1 week of 128 ods size blocks, so we need to bump the value to at least 8 levels (11 TiB). (cherry picked from commit 10351be)
walldiss
added a commit
to walldiss/celestia-node
that referenced
this pull request
Sep 25, 2023
Current instance of badger uses default value (7) for amount of used levels, that allows badger to grow up to 1.1TiB. This limit could be reaching within 1 week of 128 ods size blocks, so we need to bump the value to at least 8 levels (11 TiB). (cherry picked from commit 10351be)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current instance of badger uses default value (7) for amount of used levels, that allows badger to grow up to 1.1TiB. This limit could be reaching within 1 week of 128 ods size blocks, so we need to bump the value to at least 8 levels (11 TiB).