Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(share/store): add eds store metrics #2536

Merged
merged 3 commits into from
Aug 7, 2023

Conversation

walldiss
Copy link
Member

@walldiss walldiss commented Aug 4, 2023

Overview

I hate boilerplate, but I think it is reasonable here. If I generalise all operations right now, it will be huge pain later to modify specific ones later (like put metric is already different).

@walldiss walldiss added area:storage kind:feat Attached to feature PRs area:metrics Related to measuring/collecting node metrics labels Aug 4, 2023
@walldiss walldiss self-assigned this Aug 4, 2023
share/eds/metrics.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

Codecov Report

Merging #2536 (bc6a05b) into main (d0e271e) will decrease coverage by 1.02%.
Report is 4 commits behind head on main.
The diff coverage is 35.74%.

@@            Coverage Diff             @@
##             main    #2536      +/-   ##
==========================================
- Coverage   52.62%   51.60%   -1.02%     
==========================================
  Files         156      157       +1     
  Lines       10007    10218     +211     
==========================================
+ Hits         5266     5273       +7     
- Misses       4275     4489     +214     
+ Partials      466      456      -10     
Files Changed Coverage Δ
nodebuilder/share/opts.go 0.00% <0.00%> (ø)
share/eds/metrics.go 20.93% <20.93%> (ø)
share/eds/store.go 60.00% <60.39%> (-1.24%) ⬇️
nodebuilder/settings.go 46.90% <100.00%> (+0.95%) ⬆️

... and 9 files with indirect coverage changes

Wondertan
Wondertan previously approved these changes Aug 4, 2023
share/eds/store.go Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:metrics Related to measuring/collecting node metrics area:storage kind:feat Attached to feature PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants