feat(blob/module): integrate blob service #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vgonkivs
added
kind:feat
vgonkivs
force-pushed
the
integrate_blob_service
branch
from
9f51204 to
2ae756a
Compare
liamsi
approved these changes
May 21, 2023
vgonkivs
force-pushed
the
integrate_blob_service
branch
2 times, most recently
from
2a49dc0 to
2dd47c9
Compare
vgonkivs
force-pushed
the
integrate_blob_service
branch
from
2dd47c9 to
d31f921
Compare
Codecov Report
@@ Coverage Diff @@
## feature_branch_blob_module #2200 +/- ##
=============================================================
Coverage ? 56.18%
=============================================================
Files ? 222
Lines ? 14578
Branches ? 0
=============================================================
Hits ? 8191
Misses ? 5573
Partials ? 814 |
distractedm1nd
suggested changes
May 23, 2023
There was a problem hiding this comment.
You must integrate the blob service into the RPC client in api/rpc/client.go. This will probably also include adding an example type to api/docgen/examples.go. You can verify this works by running make openrpc-gen and confirming the output has the new methods
distractedm1nd
approved these changes
May 23, 2023
renaynay
approved these changes
May 23, 2023
|
It introduces a new component in node. I assumed that even it does not break our code but it's still a very important for node. |
|
Breaking is when something existing breaks. Solely an additional/feature is not breaking |
|
Okey |
Wondertan
reviewed
May 23, 2023
renaynay
changed the title
Co-authored-by: Hlib Kanunnikov <[email protected]>
Wondertan
reviewed
May 25, 2023
renaynay
approved these changes
May 29, 2023
vgonkivs
added a commit
that referenced
this pull request
May 29, 2023
Co-authored-by: Hlib Kanunnikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Integration of the BlobService to the node
Checklist