Document already made Decisions to Decouple Blockid and PartSetHeader in ADR 005 #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-forbes
changed the title
adlerjohn
reviewed
Aug 2, 2021
Co-authored-by: John Adler <[email protected]>
Co-authored-by: John Adler <[email protected]>
liamsi
reviewed
Aug 3, 2021
liamsi
reviewed
Aug 3, 2021
liamsi
reviewed
Aug 3, 2021
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
liamsi
reviewed
Aug 3, 2021
liamsi
reviewed
Aug 3, 2021
liamsi
reviewed
Aug 3, 2021
liamsi
reviewed
Aug 3, 2021
liamsi
reviewed
Aug 3, 2021
liamsi
reviewed
Aug 3, 2021
liamsi
reviewed
Aug 3, 2021
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
Co-authored-by: Ismail Khoffi <[email protected]>
liamsi
approved these changes
Aug 3, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a small ADR to document the decision to decouple the
PartSetHeaderfrom theBlockIDand remove it where possible. As stated in the ADR, this design is not really an alternative to other more discussed designs, but more of a short term solution and a stepping stone to other better schemes.rendered