Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small workaround to enable using the DAS light client again #413

Merged
merged 1 commit into from
Jun 13, 2021

Conversation

liamsi
Copy link
Member

@liamsi liamsi commented Jun 12, 2021

Description

See code comment of why this makes sense

@liamsi liamsi requested a review from Wondertan June 12, 2021 18:24
@liamsi liamsi force-pushed the ismail/dont_cancel_putblock branch from ee88dce to be03758 Compare June 12, 2021 18:31
@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2021

Codecov Report

Merging #413 (5a0fcd4) into master (05c1dc9) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #413   +/-   ##
=======================================
  Coverage   61.82%   61.82%           
=======================================
  Files         262      262           
  Lines       22981    22980    -1     
=======================================
  Hits        14208    14208           
+ Misses       7270     7267    -3     
- Partials     1503     1505    +2     
Impacted Files Coverage Δ
consensus/state.go 67.76% <100.00%> (-0.40%) ⬇️
libs/events/events.go 92.94% <0.00%> (-5.89%) ⬇️
p2p/switch.go 65.43% <0.00%> (-3.09%) ⬇️
blockchain/v0/pool.go 81.36% <0.00%> (-0.77%) ⬇️
statesync/syncer.go 79.76% <0.00%> (ø)
proxy/multi_app_conn.go 48.05% <0.00%> (ø)
consensus/reactor.go 73.45% <0.00%> (+0.75%) ⬆️
mempool/reactor.go 87.87% <0.00%> (+1.51%) ⬆️
p2p/pex/pex_reactor.go 81.12% <0.00%> (+2.06%) ⬆️
... and 2 more

See code comment of why this makes sense
@liamsi liamsi force-pushed the ismail/dont_cancel_putblock branch from be03758 to 5a0fcd4 Compare June 12, 2021 18:38
@liamsi liamsi requested review from evan-forbes and musalbas June 12, 2021 18:39
@liamsi liamsi marked this pull request as ready for review June 12, 2021 18:39
@liamsi liamsi merged commit 4c651f0 into master Jun 13, 2021
@liamsi liamsi deleted the ismail/dont_cancel_putblock branch June 13, 2021 11:12
evan-forbes pushed a commit that referenced this pull request Jun 9, 2023
* docs: Fix version compatibility notice in readme

Signed-off-by: Thane Thomson <[email protected]>

* Fix grammar

Signed-off-by: Thane Thomson <[email protected]>

---------

Signed-off-by: Thane Thomson <[email protected]>
(cherry picked from commit 1481f33)

Co-authored-by: Thane Thomson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants