-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adr: mvp light client #311
Merged
+299
−7
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
9b18942
First stab on mvp light client adr
liamsi 8aabbfa
Add more details about IPFS & testing
liamsi 283cfc8
Add thoughts about DAHeader via RPC
liamsi 8ab6c09
minor cleanup
liamsi 64fdfaf
more details on required changes:
liamsi c10756f
Update LightBlock comment
liamsi 96f9903
properly introduce DAHeader abbreviation and add a negative plus some…
liamsi 58b1506
Add Store requirements & note on skipping verification UX
liamsi 7d06ae2
fix sentence
liamsi cef2776
Add Provider changes
liamsi 9e8989b
Update docs/lazy-adr/adr-004-mvp-light-client.md
liamsi a062faf
Update docs/lazy-adr/adr-004-mvp-light-client.md
liamsi 257dbbc
Update docs/lazy-adr/adr-004-mvp-light-client.md
liamsi 1b119a7
Update docs/lazy-adr/adr-004-mvp-light-client.md
liamsi 0369f0f
Minor changes (title & cmd help text) and moving IPFS section
liamsi eb64c8e
Remove LAZY prefix from all ADRs
liamsi eca6147
add missing word
liamsi 64044aa
fix typo from review feedback
liamsi 2dddade
Fix diff
liamsi a275f1e
fix other diff
liamsi f3006e2
link to DAHeader earlier
liamsi 747c397
Add alternative for LightBlock and fix typo
liamsi 17c9e5a
Changes to `Client` and usage of `ValidateAvailability`
liamsi 7c91f68
cleanup some todos
liamsi 48b0430
Add note about DHT Client/Server modes
liamsi 9a08608
add numSamples to UX
liamsi 7fb463c
Update docs/lazy-adr/adr-004-mvp-light-client.md
liamsi 54b9b5d
Resolve a bunch of todos and fix sentence
liamsi 630e967
Update docs/lazy-adr/adr-004-mvp-light-client.md
liamsi e5cf047
Update docs/lazy-adr/adr-004-mvp-light-client.md
liamsi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Add Store requirements & note on skipping verification UX
- v2.0.0-tm-v0.37.2-rc0
- v1.49.0-tm-v0.34.35
- v1.48.0-tm-v0.34.35
- v1.47.0-tm-v0.34.35
- v1.46.0-tm-v0.34.35
- v1.45.0-tm-v0.34.35
- v1.44.2-tm-v0.34.35
- v1.44.1-tm-v0.34.35
- v1.44.0-tm-v0.34.35
- v1.43.0-tm-v0.34.35
- v1.42.0-tm-v0.34.35
- v1.41.0-tm-v0.34.29
- v1.40.1-tm-v0.34.29-rc0
- v1.40.0-tm-v0.34.29
- v1.39.0-tm-v0.34.29
- v1.38.0-tm-v0.34.29
- v1.37.0-tm-v0.34.29
- v1.36.1-tm-v0.34.29
- v1.36.0-tm-v0.34.29
- v1.35.0-tm-v0.34.29
- v1.34.0-tm-v0.34.29
- v1.33.0-tm-v0.34.29
- v1.32.0-tm-v0.34.29
- v1.31.0-tm-v0.34.29
- v1.30.0-tm-v0.34.29
- v1.29.0-tm-v0.34.29
- v1.28.0-tm-v0.34.29
- v1.27.0-tm-v0.34.28
- v1.26.2-tm-v0.34.28
- v1.26.1-tm-v0.34.28
- v1.26.0-tm-v0.34.28
- v1.25.0-tm-v0.34.28
- v1.24.0-tm-v0.34.28
- v1.23.0-tm-v0.34.28
- v1.22.0-tm-v0.34.28
- v1.21.2-tm-v0.34.27
- v1.21.1-tm-v0.34.27
- v1.21.0-tm-v0.34.27
- v1.20.0-tm-v0.34.27
- v1.19.0-tm-v0.34.27
- v1.18.0-tm-v0.34.27
- v1.17.0-tm-v0.34.27
- v1.16.0-tm-v0.34.27
- v1.15.2-tm-v0.34.23-bsr-rc1
- v1.15.1-tm-v0.34.23
- v1.15.1-tm-v0.34.23-BSR-hardfork
- v1.15.0-tm-v0.34.23
- v1.14.0-tm-v0.34.23
- v1.13.0-tm-v0.34.23
- v1.12.1-tm-v0.34.23
- v1.12.0-tm-v0.34.23
- v1.11.0-tm-v0.34.20
- v1.10.0-tm-v0.34.20
- v1.9.0-tm-v0.34.20
- v1.8.0-tm-v0.34.20
- v1.7.0-tm-v0.34.20
- v1.6.0-tm-v0.34.20
- v1.5.0-tm-v0.34.20
- v1.5.0-tm-v0.34.20-verify-key-patch
- v1.5.0-tm-v0.34.20-cat-simple-1
- v1.5.0-tm-v0.34.20-cat-9
- v1.5.0-tm-v0.34.20-cat-8
- v1.5.0-tm-v0.34.20-cat-7
- v1.5.0-tm-v0.34.20-cat-6
- v1.5.0-tm-v0.34.20-cat-5
- v1.5.0-tm-v0.34.20-cat-3
- v1.5.0-tm-v0.34.20-cat-2
- v1.5.0-tm-v0.34.20-cat
- v1.4.0-tm-v0.34.20
- v1.3.5-tm-v0.34.20
- v1.3.4-tm-v0.34.20
- v1.3.3-tm-v0.34.20
- v1.3.3-tm-v0.34.20-celestia-node-patch
- v1.3.2-tm-v0.34.20
- v1.3.1-tm-v0.34.20
- v1.3.0-tm-v0.34.20
- v1.1.1-tm-v0.34.16
- v1.1.0-tm-v0.34.16
- v1.0.1-tm-v0.34.16
- v1.0.0-tm-v0.34.16
- v0.34.16-celestia-rc-1
- v0.34.15-celestia
- v0.34.14-celestia
- v0.34.12-tendermint-base
- v0.34.12-celestia
- v0.0.1-mvp-das-lightclient
- tendermint-v0.34.12-base
- 1.5.0-tm-v0.34.20-cat-4
commit 58b1506bfaeae1bc4887b3661564c76d63d09128
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like we need to store
DataAvailabilityHeader
not recompute it, but to actually access block's data. You can't access block's data withoutDAHeader
, thus you can't recompute it.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things would have been so much easier if we just accessed block's data by
Header.DataHash
in the first place. We then would not need to store DAHeader in both Full and Light node stores, but only Header, as planned.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is what the text in the ADR says 🤔 With the existing code we store the Block Data but not the DAHeader and hence fullnodes can recompute it on demand. That is far from optimal but it works for the mvp.
Well, we can still do that. It's a bit orthogonal to this ADR I guess?
Wouldn't it still make sense to store the DAHeader. Especially for nodes that do not have the full block data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, that just a quick look retrospectively at how things could be done better. Nothing against this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have DataHash you can access full DAHeader, thus you can do anything you do with DAHeader, thus storing/treating it specifically is not needed, as it would be stored somewhere on the network.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That still means nodes will store the daheader in their local data stores. I guess the question here is: should we additionally store the daheader separately or not? This rather plays into adr 001 and #182. I would argue that most nodes will need the get the DAHeader and it could be useful to provide a shortcut via storing it as one blob instead of in ipld only (even if that is redundant). But maybe that is not necessary.
We will see after we (you?) have written the adr for "datahash -> DaHeader" and after we have implemented this feature. Then we can measure latencies and decide.