Skip to content

Commit

Permalink
types: fixes typo causing the roots not be hashed
Browse files Browse the repository at this point in the history
I'm not 100% certain this needs to be changed, so please disregard if not.
  • Loading branch information
evan-forbes committed Nov 20, 2020
1 parent bba6f79 commit 4b841b9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG_PENDING.md
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,5 @@ Friendly reminder, we have a [bug bounty program](https://hackerone.com/tendermi
- [statesync] \#5516 Check that all heights necessary to rebuild state for a snapshot exist before adding the snapshot to the pool. (@erikgrinaker)

### BUG FIXES

- [types] /#97 Fixes a typo that causes the row roots of the datasquare to be included in the DataAvailabilty header twice. (@evan-forbes)
2 changes: 1 addition & 1 deletion types/block.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func (dah *DataAvailabilityHeader) Hash() []byte {
for i, rowRoot := range dah.RowsRoots {
slices[i] = rowRoot.Bytes()
}
for i, colRoot := range dah.RowsRoots {
for i, colRoot := range dah.ColumnRoots {
slices[i+colsCount] = colRoot.Bytes()
}
// The single data root is computed using a simple binary merkle tree.
Expand Down

0 comments on commit 4b841b9

Please sign in to comment.