Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): upgrade to celestia-core v1.36.1-tm-v0.34.29 #3469

Merged
merged 2 commits into from
May 14, 2024
Merged

chore(deps): upgrade to celestia-core v1.36.1-tm-v0.34.29 #3469

merged 2 commits into from
May 14, 2024

Conversation

rootulp
Copy link
Collaborator

@rootulp rootulp commented May 12, 2024

Closes #3378

Testing

I updated single-node.sh to use an upgrade height so that I could verify celestia-appd status reports:

Block height App version
1 1
2 1
3 2
4 2

@rootulp rootulp self-assigned this May 12, 2024
@rootulp rootulp requested a review from a team as a code owner May 12, 2024 19:41
@rootulp rootulp requested review from cmwaters and rach-id and removed request for a team May 12, 2024 19:41
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented May 12, 2024 •
edited
Loading

Walkthrough

Walkthrough

The update to single-node.sh involves setting the initial application version to 1 and scheduling an upgrade to version 2 at block height 3. This change is designed to test the node's behavior during and after the upgrade process.

Changes

File Change Summary
scripts/single-node.sh Updated to start with app version 1 and upgrade to version 2 at block height 3. Added flag --v2-upgrade-height 3.

Assessment against linked issues

Objective Addressed Explanation
NodeInfo.protocol_version.app: 1 after upgrade to app version 2 (#3378) ❓ It is unclear if the issue is resolved as the node still reports app: 1 post-upgrade. Further investigation might be required to understand if the upgrade was not applied or if there is a reporting error.
Recent Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 3930165 and 00ee096.
Files ignored due to path filters (6)
  • go.mod is excluded by !**/*.mod
  • go.sum is excluded by !**/*.sum
  • test/interchain/go.mod is excluded by !**/*.mod
  • test/interchain/go.sum is excluded by !**/*.sum
  • test/testground/go.mod is excluded by !**/*.mod
  • test/testground/go.sum is excluded by !**/*.sum
Files selected for processing (1)
  • scripts/single-node.sh (1 hunks)
Additional comments not posted (2)
scripts/single-node.sh (2)

88-90: Change correctly sets the initial app version to 1 in the genesis configuration.

97-98: Correct implementation of the --v2-upgrade-height flag to facilitate the app version upgrade at the specified block height.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@rootulp rootulp requested review from evan-forbes and removed request for cmwaters May 12, 2024 19:41
@celestia-bot celestia-bot requested a review from a team May 12, 2024 19:41
rach-id
rach-id reviewed May 12, 2024
View reviewed changes
Copy link
Member

@rach-id rach-id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one question to understand

scripts/single-node.sh
Comment on lines +88 to +98
# Override the genesis to use app version 1 and then upgrade to app version 2 later.
sed -i'.bak' 's#"app_version": "2"#"app_version": "1"#g' "${CELESTIA_APP_HOME}"/config/genesis.json

# Start celestia-app
echo "Starting celestia-app..."
celestia-appd start \
--home "${CELESTIA_APP_HOME}" \
--api.enable \
--grpc.enable \
--grpc-web.enable
--grpc-web.enable \
--v2-upgrade-height 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we want to have these changes here? is there a reason to upgrade in the single-node.sh?

Copy link
Collaborator Author

@rootulp rootulp May 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO this is how arabica, mocha, and mainnet will behave so we should be testing it locally. It seems non representative of reality to use a genesis file that has app version 2 in it.

@rootulp rootulp requested a review from rach-id May 12, 2024 19:58
@rootulp rootulp merged commit 7828e6c into celestiaorg:main May 14, 2024
34 checks passed
This was referenced Sep 9, 2024
Merged
Merged
@coderabbitai coderabbitai bot mentioned this pull request Oct 28, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Nov 20, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Dec 6, 2024
Merged
@coderabbitai coderabbitai bot mentioned this pull request Jan 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rach-id rach-id rach-id approved these changes

@evan-forbes evan-forbes evan-forbes approved these changes

Assignees

@rootulp rootulp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NodeInfo.protocol_version.app: 1 after upgrade to app version 2
3 participants
@rootulp @rach-id @evan-forbes