Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove hardcoded Docker image from v3 e2e upgrade test #3947

Closed
rootulp opened this issue Oct 7, 2024 · 2 comments
Closed

Remove hardcoded Docker image from v3 e2e upgrade test #3947

rootulp opened this issue Oct 7, 2024 · 2 comments
Assignees
@staheri14
Labels
flup nice to have item is not blocking or required. testing items that are strictly related to adding or extending test coverage WS: V3 3️⃣ item is directly relevant to the v3 hardfork

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 7, 2024

Context

The v3 e2e test needs a slightly modified txsim. Since those modifications were introduced in the same PR as the test, we had to use "pr-3910" as the version for txsim in the test.

Proposal

Remove the "pr-3910" version from the v3 e2e upgrade test

Originally posted by @evan-forbes in #3910 (comment)
@rootulp rootulp mentioned this issue Oct 7, 2024
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Oct 9, 2024

Note there's an extra complication in addressing this issue. The v3 e2e test needs to override the upgrade height delay. We do that via built tags. The docker image used in the test needs to have the upgrade height overridden to 1. So we need to figure out a mechanism to create new Docker images for celestia-app that overrides the upgrade height to 1.

@rootulp rootulp changed the title Remove pr-3910 from v3 upgrade test Remove hardcoded Docker image from v3 e2e upgrade test Oct 9, 2024
@rootulp rootulp added the testing items that are strictly related to adding or extending test coverage label Oct 9, 2024
rootulp added a commit that referenced this issue Oct 9, 2024
@cmwaters @rootulp
test: v3 e2e upgrade (#3910)
206b96c 
Closes #3772
Opens #3947

## Testing

```
make test-e2e MajorUpgradeToV3
test-e2e2024/10/08 22:36:00 --- ✅ PASS: MajorUpgradeToV3
```

---------

Co-authored-by: Rootul P <[email protected]>
@staheri14 staheri14 mentioned this issue Oct 11, 2024
Merged
@rootulp rootulp mentioned this issue Oct 16, 2024
Closed
@rootulp rootulp added flup nice to have item is not blocking or required. WS: V3 3️⃣ item is directly relevant to the v3 hardfork and removed needs:triage labels Oct 16, 2024
@coderabbitai coderabbitai bot mentioned this issue Oct 28, 2024
Merged
@rootulp
Copy link
Collaborator Author

rootulp commented Nov 25, 2024

Closed by https://github.com/celestiaorg/celestia-app/pull/3882/files#diff-9f8a1d7b30db1f930147240dffdd19832de90abc0c1026ccb900ee601a54e208L40-L45

@rootulp rootulp closed this as completed Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@staheri14 staheri14

Labels
flup nice to have item is not blocking or required. testing items that are strictly related to adding or extending test coverage WS: V3 3️⃣ item is directly relevant to the v3 hardfork
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @staheri14