Pass connection options from broker_options to default_channel #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thedrow Thanks for the review. Please see changes. |
added 2 commits
July 31, 2017 17:59
14 tasks
46 tasks
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the best implementation, however it gets the job done for my needs. My goal is to be able to start my application when the message broker is offline. Upon startup, the application attempts to establish queues, which requires the
Channel.default_connectionto be generated. When generating thedefault_channel,Channel.ensure_connectionwith nomax_retry(or other options) provided. This caused the application to hang while infinitely attempting to connect to the broker.Fixes #765