fix azure service bus isinstance checks when None #2053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwbarnett
force-pushed
the
jwb/fix-missing-dep
branch
from
8edd7d1 to
1867154
Compare
jasonwbarnett
changed the title
Nusnus
approved these changes
Jul 9, 2024
There was a problem hiding this comment.
Thanks for the quick fix!
Just fix the lint issue and we can merge 🚀
pyupgrade................................................................Passed
autoflake................................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1
kombu/transport/azureservicebus.py:144:80: E501 line too long (109 > 79 characters)
kombu/transport/azureservicebus.py:145:80: E501 line too long (111 > 79 characters)
kombu/transport/azureservicebus.py:146:16: E111 indentation is not a multiple of 4
kombu/transport/azureservicebus.py:146:16: E117 over-indented
Strip unnecessary `# noqa`s..............................................Passed
check for merge conflicts................................................Passed
check toml...........................................(no files to check)Skipped
check yaml...............................................................Passed
mixed line ending........................................................Passed
isort....................................................................Passed
jasonwbarnett
force-pushed
the
jwb/fix-missing-dep
branch
2 times, most recently
from
d187a05 to
06b8c10
Compare
jasonwbarnett
force-pushed
the
jwb/fix-missing-dep
branch
from
06b8c10 to
9817c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2045 and #1947