azure service bus: add managed identity support #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonwbarnett
force-pushed
the
feature/add-identity-support-to-azure-service-bus
branch
from
33268aa to
ba09b8d
Compare
|
@jasonwbarnett We'd love to use this when it's complete, any chance you've found time to complete this? |
jasonwbarnett
force-pushed
the
feature/add-identity-support-to-azure-service-bus
branch
from
ba09b8d to
9ebc916
Compare
done 👍 |
|
Hi. Does this PR still need work? It seems like the rebase was done |
|
Another rebase is required, some fixes to the linting were pushed to Ping me when you rebase and if you confirm the PR is ready I'll review it quickly @jasonwbarnett |
jasonwbarnett
force-pushed
the
feature/add-identity-support-to-azure-service-bus
branch
from
9ebc916 to
9e0d704
Compare
|
@Nusnus blindly rebased and pushed just now. |
|
@auvipy Notice he edited the original PR message:
|
jasonwbarnett
deleted the
feature/add-identity-support-to-azure-service-bus
branch
|
the PR had some issues so we received another PR to address them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a work in progress. I still need to add a bunch of unit tests.
edit 1: I spent a bunch of time trying to get the unit tests to work and failed in my efforts. I have been running this code in production since this PR was originally opened (Feb 2023).