Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: handle kafka transport with confluentkafka ✨ #1574

Merged
merged 4 commits into from
Jul 2, 2024
Merged

chore: handle kafka transport with confluentkafka ✨ #1574

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db002a9
chore: handle kafka transport with confluentkafka ✨
meysam81 Jul 14, 2022
3150c01
Merge branch 'main' into meysam/kafka-transport
meysam81 Jun 27, 2024
ebc79c8
Merge branch 'main' into meysam/kafka-transport
Nusnus Jul 1, 2024
87b53ef
Merge branch 'main' into meysam/kafka-transport
Nusnus Jul 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kombu/transport/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ def supports_librabbitmq() -> bool | None:
'pyamqp': 'kombu.transport.pyamqp:Transport',
'librabbitmq': 'kombu.transport.librabbitmq:Transport',
'confluentkafka': 'kombu.transport.confluentkafka:Transport',
'kafka': 'kombu.transport.confluentkafka:Transport',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might add another back end in near future, like aiokafka, so i am not in favor of adding this change right now :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well @auvipy , for the moment, you would want to give some API to the already-implemented logic. If in the future, you plan to change the logic, you'd just change one line here. No hard feelings :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because you see, at the moment, I'm giving confluentkafka://kafka.kafka.svc.cluster.local to my app. which is ugly when you think about it.

'memory': 'kombu.transport.memory:Transport',
'redis': 'kombu.transport.redis:Transport',
'rediss': 'kombu.transport.redis:Transport',
Expand Down