-
-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kafka support #1506
Kafka support #1506
Conversation
for more information, see https://pre-commit.ci
This pull request introduces 1 alert when merging 52fb571 into aab2588 - view on LGTM.com new alerts:
|
# Conflicts: # kombu/transport/confluentkafka.py
This pull request introduces 1 alert when merging 39da6bb into aab2588 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 6c6acb5 into aab2588 - view on LGTM.com new alerts:
|
Can you add also a documentation to head of file - see redis transport as an example: kombu/kombu/transport/redis.py Lines 1 to 52 in aab2588
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a rebase & docs update needed
Co-authored-by: Asif Saif Uddin <[email protected]>
for more information, see https://pre-commit.ci
This pull request introduces 2 alerts when merging 3b7d903 into 14d395a - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging 9a1fe95 into 14d395a - view on LGTM.com new alerts:
|
Seems like confluent-kafka-python doesn't support PyPy. So had to disable PyPy tests for kafka. |
that's OK, we just need to mention it on docs/release notes |
This pull request introduces 1 alert when merging 6cec1e9 into 14d395a - view on LGTM.com new alerts:
|
Based on #600 but switched from pykafka to https://github.com/confluentinc/confluent-kafka-python as pykafka project was archived.
Also aiokafka was mentioned here, but I didn't find any usages of asyncio libraries in Kombu. Thus I assumed that the best option for me would be confluent-kafka-python.
Integration tests are green, but had to exclude BaseTimeToLive and BasePriority tests because Kafka does not allow to set expiration time per message, as well as it does not provide message priority feature (Kafka partition is an immutable ordered log of messages).
I'm not sure about the relevance of my PR (maybe you meant to use another library), so let me know if it makes sense.