Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid long_description #255

Merged
merged 1 commit into from
May 22, 2019
Merged

Fix invalid long_description #255

merged 1 commit into from
May 22, 2019

Conversation

di
Copy link
Contributor

@di di commented May 22, 2019

This PR fixes invalid syntax in README.rst which will prevent upload to PyPI. Fixes #254.

Before:

$ python setup.py sdist bdist_wheel
...
$ twine check dist/*
Checking distribution dist/django_celery_beat-1.4.0-py2.py3-none-any.whl: warning: `long_description_content_type` missing.  defaulting to `text/x-rst`.
Failed
The project's long_description has invalid markup which will not be rendered on PyPI. The following syntax errors were detected:
line 218: Warning: Inline literal start-string without end-string.
Checking distribution dist/django-celery-beat-1.4.0.tar.gz: warning: `long_description_content_type` missing.  defaulting to `text/x-rst`.
Failed
The project's long_description has invalid markup which will not be rendered on PyPI. The following syntax errors were detected:
line 218: Warning: Inline literal start-string without end-string.
line 218: Warning: Inline literal start-string without end-string.

With this change:

$ python setup.py sdist bdist_wheel
...
$ twine check dist/*
Checking distribution dist/django_celery_beat-1.4.0-py2.py3-none-any.whl: warning: `long_description_content_type` missing.  defaulting to `text/x-rst`.
Passed
Checking distribution dist/django-celery-beat-1.4.0.tar.gz: warning: `long_description_content_type` missing.  defaulting to `text/x-rst`.
Passed

Copy link
Member

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am surprised to see your PR!! thanks a lot :D

@auvipy auvipy merged commit 0bf9ff4 into celery:master May 22, 2019
@di di deleted the fix-254 branch May 22, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI release blocked by warehouse bug
2 participants