Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dBVH memcpy size #1490

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Fix dBVH memcpy size #1490

merged 1 commit into from
Nov 7, 2024

Conversation

esseivaju
Copy link
Contributor

Introduced in #1481, copy the entire pointer instead of 1 byte.

@esseivaju esseivaju added bug Something isn't working minor Minor internal changes or fixes labels Nov 7, 2024
@esseivaju esseivaju requested a review from sethrj November 7, 2024 21:42
pcanal
pcanal approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding this!

@pcanal pcanal self-assigned this Nov 7, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Test summary

 3 386 files   5 238 suites   3m 53s ⏱️
 1 583 tests  1 555 ✅ 28 💤 0 ❌
17 458 runs  17 392 ✅ 66 💤 0 ❌

Results for commit 6067599.

@esseivaju
Copy link
Contributor Author

Missed that in the review, better late than never 😅

@pcanal pcanal merged commit 3e0a2be into celeritas-project:develop Nov 7, 2024
34 checks passed
@pcanal
Copy link
Contributor

pcanal commented Nov 7, 2024

Does it fix the crash related to dBVH?

@sethrj
Copy link
Member

sethrj commented Nov 7, 2024

This was only for the diagnostic. Sorry I didn't notice it!

@esseivaju
Copy link
Contributor Author

right, it's only for the diagnostic, and that line is still showing up in a full static build of AthSimulation+AthExternals

@esseivaju esseivaju deleted the fix-dBVH-memcpy branch November 19, 2024 22:13
@sethrj sethrj added core Software engineering infrastructure and removed bug Something isn't working labels Dec 12, 2024
sethrj pushed a commit to sethrj/celeritas that referenced this pull request Jan 14, 2025
@esseivaju @sethrj
Fix dBVH memcpy size (celeritas-project#1490)
dca88f9
sethrj pushed a commit to sethrj/celeritas that referenced this pull request Jan 14, 2025
@esseivaju @sethrj
Fix dBVH memcpy size (celeritas-project#1490)
fe20c74
sethrj pushed a commit that referenced this pull request Jan 14, 2025
@esseivaju @sethrj
Fix dBVH memcpy size (#1490)
6df2933
sethrj pushed a commit that referenced this pull request Jan 14, 2025
@esseivaju @sethrj
Fix dBVH memcpy size (#1490)
937632f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcanal pcanal pcanal approved these changes

@sethrj sethrj Awaiting requested review from sethrj

Assignees

@pcanal pcanal

Labels
core Software engineering infrastructure minor Minor internal changes or fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@esseivaju @pcanal @sethrj