Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton optical core params and launch action #1386

Merged
merged 6 commits into from
Sep 4, 2024

Conversation

sethrj
Copy link
Member

@sethrj sethrj commented Aug 31, 2024

This adds the basic structure for the optical core params and state to be used in the tracking loop, and it adds the "optical launch action" that can access both the offload data and the launch state.

@sethrj sethrj added enhancement New feature or request physics Particles, processes, and stepping algorithms labels Aug 31, 2024
@sethrj sethrj force-pushed the optical-core-params branch from 06a5e2f to 3fca57f Compare September 1, 2024 19:20
@sethrj sethrj marked this pull request as ready for review September 3, 2024 13:14
@sethrj sethrj changed the title Add optical core params and launch action Add skeleton optical core params and launch action Sep 3, 2024
@sethrj
Copy link
Member Author

sethrj commented Sep 3, 2024

@amandalund Even though this doesn't have enough functionality to be useful, I think it's at a decent merging point... I think we could split up the next steps once this is in?

Copy link
Contributor

@amandalund amandalund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! This is a great starting point, and now that the skeleton’s in place we can move forward with the stepping loop and modify these classes as needed as we go. Thanks!

@sethrj sethrj merged commit 8b327e0 into celeritas-project:develop Sep 4, 2024
29 checks passed
@sethrj sethrj deleted the optical-core-params branch September 4, 2024 12:47
@amandalund amandalund mentioned this pull request Oct 17, 2024
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request physics Particles, processes, and stepping algorithms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants