Added command line support for using local CEF builds #44
Conversation
Example for vs2015 and nupkg-only with local custom build of Cef branch 2924 .\build.ps1 -Target vs2015 -DownloadBinary local -CefVersion 3.2924.1538.gbfdeccd -CefBinaryDir "../../cefsource/chromium/src/cef/binary_distrib/" .\build.ps1 -Target nupkg-only -DownloadBinary none -CefVersion 3.2924.1538.gbfdeccd
Apart from that looks fine, usage examples are a nice touch 👍 |
|
@amaitland ah yep sorry, edited in the crappy Windows Powershell ISE |
|
@amaitland: I'm assuming you are referring to the braces in the switch statement (I've changed now to reflect other switch statements. But again it is fairly inconsistent through out. I'll await further feedback before committing. I'm not going to change any existing functions (which have 2 spaces instead of 4, inconsistent braces), but if you would like me to adjust what I have added to a particular style then please advice correct style (my guess, 4 spaces indent, braces begin on new line). |
| { | ||
| DownloadCefBinaryAndUnzip | ||
| "none" { |
| sleep -m 2000 | ||
| #Remove tar file | ||
| Remove-Item $TarFile | ||
| $Folder = Join-Path $WorkingDir ($Cef64FileName.Substring(0, $Cef64FileName.length - 8)) |
There was a problem hiding this comment.
Indentation is out. Assuming you copied this and the original indentation is out and you have time please fix that also.
| { | ||
|
|
||
| Write-Diagnostic "Copy $Cef64FileName (approx 200mb)" | ||
| Copy-Item ($CefBuildDir+$Cef64FileName) $LocalFile; |
| sleep -m 2000 | ||
| #Remove tar file | ||
| Remove-Item $TarFile | ||
| $Folder = Join-Path $WorkingDir ($Cef32FileName.Substring(0, $Cef32FileName.length - 8)) |
|
Merging now, I'll worry about the formatting later 👍 |
|
Ok no worries, nearly finished, but yeah might be better to do the whole file in one go. Enjoy! |
Yep, it's a mess! Oh well. A problem for another day. |
Added command line support for using local CEF builds Former-commit-id: 8e8770ee9d7073e25173731400a012d6b44f9eb0
Added command line support for using local CEF builds Former-commit-id: 8e8770ee9d7073e25173731400a012d6b44f9eb0
Example for vs2015 and nupkg-only with local custom build of Cef branch 2924