Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep cef.redist.targets from copying unchanged files #40

Merged
merged 1 commit into from
May 31, 2016
Merged

Keep cef.redist.targets from copying unchanged files #40

merged 1 commit into from
May 31, 2016

Conversation

loganmu
Copy link
Contributor

@loganmu loganmu commented May 30, 2016

Hey guys @amaitland @jornh

I've experienced VS2015 IDE blocking sometimes up to 30 seconds in certain environments and was able to narrow it down to these tasks. Since some of the files are pretty sizable, would it be all right to include the SkipUnchangedFiles attribute on these?

https://msdn.microsoft.com/en-us/library/3e54c37h%28v=vs.120%29.aspx

Thanks,
Logan

@amaitland
Copy link
Member

Since some of the files are pretty sizable, would it be all right to include the SkipUnchangedFiles attribute on these?

@loganmu Have you tried the proposed changes? Sounds reasonable on the surface of it.

@loganmu
Copy link
Contributor Author

loganmu commented May 31, 2016

@amaitland Yes 👍 for the past week or so. Have confirmed that new changes continue to get picked up when new binaries are dropped (MSBuild successfully follows filesize and time)

@amaitland
Copy link
Member

@loganmu Great 👍 Thanks for confirming.

@amaitland amaitland merged commit a4e8cae into cefsharp:master May 31, 2016
@loganmu loganmu deleted the suggestion/SkipUnchangedTargets branch May 31, 2016 02:46
merceyz pushed a commit that referenced this pull request Apr 12, 2017
Keep cef.redist.targets from copying unchanged files

Former-commit-id: c0c4d433ce11b1760076ba00d49e74d63a564059
merceyz pushed a commit that referenced this pull request Apr 12, 2017
Keep cef.redist.targets from copying unchanged files

Former-commit-id: c0c4d433ce11b1760076ba00d49e74d63a564059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants