-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for building 3.1750.1738 #11
Conversation
…big deal to manually download the required files yourself
Additional information is available here: #9 |
I have also removed the binary files since github goes crazy when we are talking about blobs larger than 100MB. But it's maybe a 5 minute operation of manually downloading the binary files and extracting each of them to their respective folder. Somebody should use bfg and prune all binary files. |
NB! If you need to test the VS2010 build you can simply run |
/cc @amaitland @jornh |
I guess all that's remaining here is to have somebody that has a working VS2010 installation produce ze nuget package and we are good to go! IMHO i would drop support for v100 :)))))))) |
@peters Awesome work, thanks! I think there was some talk previously about dropping support for @jornh What do you think about publishing a nuget package? I know #10 is something you were working on, do you think we should push that to completion first? |
I'm wondering if there's a way to fully automate the build process. How hard would it be for the Alternatively we could commit the zipped versions and have the script extract them, not nearly as nice, though somewhat in between the two solutions, more user/git friendly, fully automated. I'd like to back port |
@amaitland Automatic download of prerequisites is fixed in d4d6a15 :) |
@peters that should simplify the process 😄 Much appreciated! |
Yes, awesome indeed! In particular the last commit reduced the 3 steps to just: I like that you kicked out the big binary files. But in doing so you also broke the license url we use in the
Agree, let's do it! If someone really needs to build CefSharp from source with VS2010 it's now super easy for them to make their own
Nah, I'm fine with getting this PR #11 in first. Either way one of the PRs need changes to fit with the other, might as well be PR #10 being rewritten... |
I've created a branch on https://github.com/cefsharp/cef-binary/tree/cef-1750 Make sure his fine work gets included and can be easily referenced by others 😄 |
What are your thought on this:
I think with a solution to this it's ready for merge. So @amaitland please go ahead if you want. Then if you can point me to a Right? (Gotta' run for work now) |
@jornh Sounds like a plan, I'll merge this now, then fix the links in the |
Add support for building 3.1750.1738
@jornh I've built a |
Great! If you create yourself a profile on www.nuget.org and/or http://staging.nuget.org (for practicing) I can add you as owner so you can |
I've created an account on both, same username as on here. I'm happy to push a version to staging nuget. Then we can verify that it's ready for a wider release. I tried uploading to myget, it got part way through the upload and cancelled, unsure if the file size was an issue, or if the amount of time it was taking was too long and it timed out. |
U got mail from NuGet.org 😄 I had the same problem with Maybe there's a timeout setting on NuGet.exe? Still I'm a bit worried if people will get download problems too, but I guess most have better download than upload performance... |
Mail received 😄 I looked up |
I got all the way through uploading only to get a permission error, I forgot to click the links in the email! lol |
Packages have been uploaded to |
I'm getting this error when using the dll's produced by
If I manually edit the @peters Any thoughts? Am I missing something? Everything worked when you built your |
@amaitland Hmm.. it is related to https://github.com/cefsharp/cef-binary/blob/master/build.ps1#L220. This only affects the x86 version right? |
Doesn't appear to work out of the box for either version. I take it you had no problems with yours? |
I've created PR #13 decided it was easy to just take the manual step of editing the project files and automate it. I'm pushing another |
@amaitland Yup, it's a black box so i guess #13 is the best way to go about it. Simple as she goes 👍 |
üüüü 👯 |
Add support for building 3.1750.1738 Former-commit-id: 6c07fd71e747b5e72e167b7c69e1940c5ffcb257
Add support for building 3.1750.1738 Former-commit-id: 6c07fd71e747b5e72e167b7c69e1940c5ffcb257
Build steps:
I've disabled VS2010 build since i don't have a copy of it available, but you can simply uncomment it
Nuget packages for VS2012 / VS2013 (x86 & x64) are available here.
👯 💯