Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Javascript Binding - Store JavascriptObjects per CefBrowser #4475

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

amaitland
Copy link
Member

@amaitland amaitland commented Apr 18, 2023

Fixes: #2306

Summary:

  • Historically JSB objects are cached per process, for shared render processes this can be problematic
    This optionally allows for a new Per Browser cache.

Use the following command line arg to opt into this behaviour.

--jsb-cache-perbrowser
// CefSettings
settings.CefCommandLineArgs.Add("jsb-cache-perbrowser");

Changes:

  • Add cache abstraction to allow for legacy and new per browser configuration
  • Add new CefSharp specific command line arg to optionally enable new code path
  • Settings haven't been moved to per Browser as that requires additional code changes to pass in extraInfo to the Popups

How Has This Been Tested?
TODO: Add tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@AppVeyorBot
Copy link

@AppVeyorBot
Copy link

@amaitland amaitland force-pushed the jsb/perbrowsercache branch from f18c0ff to 8eb2376 Compare August 5, 2023 20:06
@AppVeyorBot
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript Binding - Store JavascriptObjects/Settings per CefBrowser
3 participants