Added default implementation of IRequestHandler #2157
Conversation
|
@martinekvili Thanks for the PR. Could you resolve the conflicts? We can then review it. |
perlun
added
more-details-needed-from-op
not-ready-for-merge
and removed
more-details-needed-from-op
labels
|
✅ Build CefSharp 62.0.0-CI2386 completed (commit 212714fe1c by @martinekvili) |
|
@perlun Thanks, the conflicts should be sorted now. |
|
@amaitland Since you requested the original change, I think it would make most sense if you review this. Let me know if you are unable to do this and we'll let someone else give it a look. |
|
@perlun Seems reasonable, will have a look 👍 |
CefSharp/DefaultRequestHandler.cs
Outdated
|
|
||
| using System.Security.Cryptography.X509Certificates; | ||
|
|
||
| namespace CefSharp |
There was a problem hiding this comment.
At a minimum this should be in the Handler folder. Probably the CefSharp.Handler namespace as well. (Ideally all the handlers should be in their own namespace, moving the interfaces is a massive breaking change, so probably won't happen).
CefSharp/DefaultRequestHandler.cs
Outdated
| /// </summary> | ||
| public class DefaultRequestHandler : IRequestHandler | ||
| { | ||
| public virtual bool GetAuthCredentials(IWebBrowser browserControl, IBrowser browser, IFrame frame, bool isProxy, string host, |
There was a problem hiding this comment.
Ideally the xmldoc would be copied from the parent IRequestHandler. GhostDoc is handy when it comes to this sort of thing.
|
✅ Build CefSharp 62.0.0-CI2389 completed (commit a135f0a777 by @martinekvili) |
|
@amaitland Thank you very much for the feedback! I think I implemented all the requested changes. |
|
@amaitland AppVeyor has stalled on this one for some reason, but I'm fine with you merging this nonetheless. |
A new default implementation was added in #2157 BrowserTabView - cleanup usings and remove unused code
martinekvili
deleted the
feautre/irequesthandler-default-implementation
branch
This PR was requested by @amaitland in issue #1437, but as far as I was able to tell, it was never implemented.