Fixed process not exiting in Windows XP #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a handler assignment on the first call to CefSharp::Initialize which will ensure CEF is shutdown properly should the calling program not manually call the shutdown method before the process exits. This bug only seems to affect Windows XP, however I have tested on both Windows XP and Windows 7 and with this change neither have any ghost processes left over after the program calling CefSharp exits. This commit fixes #80
perlun
added a commit
that referenced
this pull request
Oct 23, 2013
Fixed the "process not exiting in Windows XP" bug.
|
Thanks @rastating! 😄 Of course, it's much better to have this fixed than just ignoring Windows XP, so I'm glad you could help out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a handler assignment on the first call to CefSharp::Initialize
which will ensure CEF is shutdown properly should the calling program
not manually call the shutdown method before the process exits.
This bug only seems to affect Windows XP, however I have tested on both
Windows XP and Windows 7 and with this change neither have any ghost
processes left over after the program calling CefSharp exits.
This commit fixes #80