-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add paramArray support to Javascript Binding #1644
Conversation
@@ -351,6 +351,14 @@ <h3 id="features-javascript-integration">JavaScript integration</h3> | |||
objects. | |||
</p> | |||
<h3>Hooks by which you can modify and/or override certain features of the web browsing</h3> | |||
<p> | |||
A fix to allow params to be used by the .NET methods called by the javascript<br /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be in BindingTest.html
. Also having A fix to allow params to be used by the .NET methods called by the javascript
is not really relevant to someone using CefSharp
. Simple description of what your demoing would be better 👍
@ChrisBardsley Welcome, and thanks for the contribution 😄 Comments inline, by all means ask any questions for clarification. I'd also like to rename this to something simple like
|
@ChrisBardsley Any further comment on this? Initially I was planning on this being in the |
@ChrisBardsley Merged with changes, see 669404f (comments welcome) I'll review one more time in the next few days before merging into the Thanks for the contribution 👍 |
There seems to be a problem with managing missing/optional parameters. |
@ray007 Please open a new issue. Ideally submitting a |
This fix allow you to use a params array for a parameter in your C# object that is bound to your javascript functions.