Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to dock properly #553

Closed
architkshk opened this issue Oct 31, 2014 · 16 comments
Closed

Unable to dock properly #553

architkshk opened this issue Oct 31, 2014 · 16 comments

Comments

@architkshk
Copy link

when i open new tab in my application having chromium web browser it open but it don't dock properly.

@jornh
Copy link
Contributor

jornh commented Oct 31, 2014

Well that's not a lot of information to start helping you from. Please use the example applications we provide both in this repo and CefSharp.MinimalExample and see if you can reproduce ... Also please see https://github.com/cefsharp/CefSharp/wiki/Trouble-Shooting#still-having-problems

@jornh jornh added the question label Oct 31, 2014
@architkshk
Copy link
Author

1
i've attached the problem....

@sylvain-hamel
Copy link
Contributor

We have the same intermittent problem here and we are currently investigating it. Re-sizing the container form fixes it. We don't have the steps to reproduce yet.

@architkshk
Copy link
Author

ya, resizing fixes it.......

@jornh
Copy link
Contributor

jornh commented Oct 31, 2014

OK, @sylvain-hamel since you submitted #536 I guess you are on the JsBinding_WIP branch, right? Thanks for that one 👍 btw!

And I guess from the "yeah, resizing fixes it" that you are both on WinForms ...?

If so please note that the fixes in master between release 33.0.0 and 33.0.2 have not been applied to JsBinding_WIP nor the -pre NuGet yet.

@sylvain-hamel
Copy link
Contributor

@jornh, yes on JsBinding_WIP (you are welcome btw), yes on Windows Forms. We'll try to reproduce it on master but I don't think we'll be able to do so because we rely heavily on js binding. I don't think our app will load correctly.

Are there recent fixes in master that you think can fix this? Can you tell me which ones, we could cherry pick those to test if they fix the issue.

@asarchit65 are you on JsBinding_WIP too?

@jornh
Copy link
Contributor

jornh commented Oct 31, 2014

It's #512, #513 and the few commits in #521 that are not just updates to the Example code as far as I can see. Then you of course might need to unload the Example project.

@jornh
Copy link
Contributor

jornh commented Oct 31, 2014

Nope, sorry apparently the good @amaitland already merged those! Forget my last comment.

@amaitland
Copy link
Member

Is the issue present in the 'WinForms Example'? I was see that issue, was hopeful it's fixed.

@jornh
Copy link
Contributor

jornh commented Nov 1, 2014

@amaitland I think there is still hope that the fixes in the three PRs I mentioned above fixes it. Your fixes were merged into JsBinding_WIP only two days ago with 52db1e2 right?

This must mean that if @sylvain-hamel has seen issues with code from before that merge-point new testing has to be done before we can conclude anything new.

@asarchit65 a screenshot in itself doesn't really help us help you, we need some steps to reproduce. Only thing we can see is that you are most likely building a tabbed browser UI. For that I suggest you take a look at latest CefSharp.Example.WinForms and work from there.

@amaitland
Copy link
Member

@amaitland I think there is still hope that the fixes in the three PRs I mentioned above fixes it. Your fixes were merged into JsBinding_WIP only two days ago with 52db1e2 right?

@jornh That is a very valid point, it was very recently that I merged those changes from master, guess we'll see what feedback comes from it.

@sylvain-hamel
Copy link
Contributor

Hi guys, I updated my branch with the new code and I still have the bug, but things have improved.

As a workaround, I can now call Refresh() in webBrowser_IsBrowserInitializedChanged and it fixes the problem. This fix did not work without the new code. I'll keep this workaround until this gets fixed for real.

By the way, I'm building a tabbed interface too. The tab component by Janus. The bug might be cause by the fact that the control is created while it is not actually visible on the screen.

@sylvain-hamel
Copy link
Contributor

@jornh , @amaitland did you see my last comment? Any thoughts on what could be the cause? Do you think you can work on this issue even without a proper repro project?

@amaitland
Copy link
Member

@sylvain-hamel Without an easy way to reproduce the issue it's quite difficult to investigate this further. Thoughts?

@amaitland
Copy link
Member

There's also the option of trying a newer version of Cef, the latest version that includes JS Binding is here https://github.com/cefsharp/CefSharp/tree/cef/2062-jsb-wip

There's also an even newer version of Cef, though JS binding is absent from that branch https://github.com/cefsharp/CefSharp/tree/cef/2171

Also it might be worth having a look at #522

@sylvain-hamel
Copy link
Contributor

@amaitland Ok. I'll give it a try later this week. For now my workaround is viable.

sylvain-hamel added a commit to Octopus-ITSM/CefSharp that referenced this issue Nov 18, 2014
sylvain-hamel added a commit to Octopus-ITSM/CefSharp that referenced this issue Nov 18, 2014
sylvain-hamel added a commit to Octopus-ITSM/CefSharp that referenced this issue Nov 18, 2014
amaitland added a commit that referenced this issue Nov 19, 2014
fix #553 by handling Initial resize and OnSizeChanged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants