JS binding causes memory leak in 65+

[chylex]

• What version of the product are you using?

  • Reproduced from c37dbcd (commit after upgrade to CEF 65) to 22b299e (latest master w/ 66)

• What architecture x86 or x64?

  • Both x86 and x64

• On what operating system?

  • Tested on Win 7 & 10

• Are you using WinForms, WPF or OffScreen?

  • WinForms

• What steps will reproduce the problem?

  • Using RegisterAsyncJsObject on a browser and then reloading that browser keeps increasing memory usage and never releases it

• Reproduction example

  • Get https://github.com/chylex/CefSharp/commit/cd9dad63f6bb6555d54a6a7526820eb0c899688e and run CefSharp.WinForms.Example
  • Repeatedly click Go or reload the page, memory usage of the subprocess should keep rising forever

[amaitland]

Appears to be a problem with the newer binding method also.

[amaitland]

The destructor isn't being called in newer branches for the CefV8Handler implementations so the process is leaking memory 😦

It appears to be related to how we're currently storing a CefV8Value reference to the promise creator function used by the async code. It's possible to obtain the promise on Execute so we don't need to hold the reference. The destructor seems to be called now, so memory is freed.

Relevant commit for cefsharp/65 is 930846e and for master see 5f3dca4

[amaitland]

Reproduction example

Get chylex/CefSharp@cd9dad6 and run CefSharp.WinForms.Example
Repeatedly click Go or reload the page, memory usage of the subprocess should keep rising forever

@chylex Thanks for taking the time to create a example, greatly appreciated 👍

[chylex]

Tested with latest build, appears to be working fine now. Thanks!

[amaitland]

Thanks for checking 👍

Closing as appears the problem is resolved.