Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address larger tech debt/TODOs #8

Merged
merged 5 commits into from
May 5, 2020
Merged

Address larger tech debt/TODOs #8

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
64f37b8
Fix optional chaining TODO
cee-chen May 4, 2020
534f98c
Fix constants TODO
cee-chen May 4, 2020
48d4fb7
Remove TODO for eslint-disable-line and specify lint rule being skipped
cee-chen May 4, 2020
6ce27ec
Add server-side logging to route dependencies
cee-chen May 4, 2020
75f8e77
Move more Engines Overview API logic/logging to server-side
cee-chen May 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions ...rise_search/public/applications/app_search/components/engine_overview/engine_overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,12 +49,8 @@ export const EngineOverview: ReactFC<> = () => {
};
const hasValidData = response => {
return (
response &&
Array.isArray(response.results) &&
response.meta &&
response.meta.page &&
typeof response.meta.page.total_results === 'number'
); // TODO: Move to optional chaining once Prettier has been updated to support it
Array.isArray(response?.results) && typeof response?.meta?.page?.total_results === 'number'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah rad, I didn't realize we could start use this.

);
};
const hasNoAccountError = response => {
return response && response.message === 'no-as-account';
Expand Down