Combine with kibana#163137 #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
reviewed
Aug 4, 2023
| ...props | ||
| }) => { | ||
| return ( | ||
| <i18n.Context> | ||
| <KibanaThemeProvider {...props}> | ||
| <EuiErrorBoundary>{children}</EuiErrorBoundary> |
There was a problem hiding this comment.
Does the lost <EuiErrorBoundary> matter here at all? No worries if not, just thought I'd check!
cee-chen
reviewed
Aug 4, 2023
| <EuiErrorBoundary>{children}</EuiErrorBoundary> | ||
| </KibanaThemeProvider> | ||
| </i18n.Context> | ||
| <KibanaRootContextProvider globalStyles={false} {...props}> |
There was a problem hiding this comment.
Love this DRYness! I was going to ask you earlier if you thought it would be weird to have the RenderContext reuse the RootContext - glad to know I wasn't totally crazy 😆
cee-chen
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commit which combines elastic#163103 with elastic#163137.
@cee-chen feel free to merge this to your PR, or chat with me more tomorrow? Thanks!