Skip to content
This repository has been archived by the owner on Aug 3, 2024. It is now read-only.

Indicate that GCS adapter can overwrite file #13

Merged
merged 2 commits into from
Feb 2, 2021

Conversation

daohoangson
Copy link
Contributor

This PR implements the interface \League\Flysystem\Adapter\CanOverwriteFiles for GoogleCloudStorageAdapter to optimize away a Filesystem::has call. It looks like this in \League\Flysystem\Filesystem:

        if ( ! $this->getAdapter() instanceof CanOverwriteFiles && $this->has($path)) {
            return (bool) $this->getAdapter()->updateStream($path, $resource, $config);
        }

@daohoangson
Copy link
Contributor Author

@cedricziel, can you take a look?

@cedricziel cedricziel merged commit 48929f6 into cedricziel:master Feb 2, 2021
@cedricziel
Copy link
Owner

Thank you for your contribution, @daohoangson ! Sorry for being late :/

@daohoangson daohoangson deleted the can_overwrite_Files branch February 3, 2021 03:01
@daohoangson
Copy link
Contributor Author

Thank you for merging! @cedricziel

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants