Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added: shi-tomashi corner generator #32

Merged

Conversation

thundersparkf
Copy link
Contributor

Added a Shi-Tomashi corner generator module

Since corner generation is more dynamic in the pixels used, it would offer a better data abstraction. Plus it is also difficult to ascertain the how many corners were computed by any attacker.

Please let me know if there are any issues
Signed-off-by: thundersparkf [email protected]

@thundersparkf thundersparkf force-pushed the feat/shi_tomashi_generator branch from d5ed931 to c774e9e Compare November 22, 2021 21:38
@cedricbonhomme
Copy link
Owner

This seems to be an excellent contributions ;-) Thank you very much !
I will have a deeper look tomorrow about this Shi-Tomashi corner generator.

@cedricbonhomme cedricbonhomme merged commit 4a65762 into cedricbonhomme:master Nov 22, 2021
@cedricbonhomme
Copy link
Owner

Hi,
I have a small question... Where is the best place to round (or cast to int) the value here:
https://builds.sr.ht/~cedric/job/633518#task-test-103
x and y are not equal. I would like to make the test happy ;-)

@thundersparkf
Copy link
Contributor Author

Hey! Yes

Firstly, this for consistency's sake the min_distance parameters needs to be changed to 10.0
Screenshot 2021-11-24 at 1 07 52 PM

And then also the
np.int0 line must be removed
Screenshot 2021-11-24 at 1 08 18 PM

@cedricbonhomme
Copy link
Owner

Perfect, it works. I just had to use assert_allclose with a custom relative tolerance.

https://github.com/cedricbonhomme/Stegano/blob/master/tests/test_generators.py#L180

I'll create a new release a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants