Fix PublicKeyCredential::Options#.as_json not camelCase'ing keys of attributes with hash or arrays as values
#445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…amelCase keys in Rails
In Rails, doing
```
WebAuthn::Credential.options_for_create(user: { name: 'john', id: WebAuthn.generate_user_id }, authenticator_selection: { user_verification: "required" }).as_json
```
results in:
```
{:challenge=>"QVFtcdn_znYUWzAzmBSGpOPWweTs1tBmqPQENeGjUvA",
:timeout=>120000,
:extensions=>{},
:rp=>{:name=>"WebAuthn Rails Demo App"},
:user=>{:name=>"john", :id=>"8kzxeLCJ13lE5g7T7pE0TxCRxy_4Mcpp1lWS6geXJAiz7rPXHOWSJy_Ou33GP7lCvn_u5uIhDZzOez_cWoMGcA", :displayName=>"john"},
:pubKeyCredParams=>[{"type"=>"public-key", "alg"=>-7}, {"type"=>"public-key", "alg"=>-37}, {"type"=>"public-key", "alg"=>-257}],
:authenticatorSelection=>{"user_verification"=>"required"}}
```
(Notice the `user_verification` key under `authenticatorSelection`
without being camelCased)
This causes errors with some authenticators – particularly with
1Password.
The issue is that for the attributes whose value is a hash – as in
Rails, hash objects respond to `as_json` – are not going through the
part of the condition that calls camelCases its keys.
To fix this, this commit attempts to go back at the initial approach -
before 0aab124 – that first converts the object into a hash and then
camel cases its keys, even though more iterations are performed on the
object.
brauliomartinezlm
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts to fix #444.
To fix this, this commit attempts to go back at the initial approach - before 0aab124 – that first converts the object into a hash and then camel cases its keys, even though more iterations are performed on the object.