Extract shared logic for serializing credential options into a new JSONSerializer module
#438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagorodriguez96
force-pushed
the
sr--add-json-serializer
branch
from
4ac971b
to
78ddf37
Compare
brauliomartinezlm
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #436.
There are a couple of additional methods used for serializing the objects that were shared between
WebAuthn::PublicKeyCredential::OptionsandWebAuthn::PublicKeyCredential::Entity.This PR attempts to extract them into the same module as we started to do in #436 after removing
awrence.Now our classes can include the
JSONSerializermodule and define anattributesmethod and they will be able to callas_jsonwhich will return a hash with the defined attributes as keys and their respective values – which if they were hashes, their keys will be deeply converted to camelcase.