Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket #216: Don't sort None value #220

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Ticket #216: Don't sort None value #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions lib/Shine/CLI/Display.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,17 +156,10 @@ def fieldvals(comp):
comps.groupby(key=fieldvals) ]

# Sort
def sorter(compgrp):
"""
Sort grplist based on provided sort_key for the first element of
compgrp.
"""
(first, _) = compgrp
if sort_key is None:
return None
return sort_key(first)

for first, compgrp in sorted(grplst, key=sorter):
if sort_key is not None:
grplst.sort(key=lambda group: sort_key(group[0]))

for first, compgrp in grplst:

# Get component fields
fields = _get_fields(first, pat_fields)
Expand Down
Loading