Ticket #216: Don't sort None value (#220)

In Shine.CLI.Display, instead of returning None when sorting without sorting parameter, just don't sort at all. Avoid trying to sort and compare None value with is no more sortable. Co-authored-by: Aurelien Degremont <[email protected]>
cea-hpc · Jul 25, 2024 · e3e5be4 · e3e5be4
1 parent 4e85185
commit e3e5be4
Showing 1 changed file with 4 additions and 11 deletions.
diff --git a/lib/Shine/CLI/Display.py b/lib/Shine/CLI/Display.py
@@ -156,17 +156,10 @@ def fieldvals(comp):
                comps.groupby(key=fieldvals) ]
 
     # Sort
-    def sorter(compgrp):
-        """
-        Sort grplist based on provided sort_key for the first element of
-        compgrp.
-        """
-        (first, _) = compgrp
-        if sort_key is None:
-            return None
-        return sort_key(first)
-
-    for first, compgrp in sorted(grplst, key=sorter):
+    if sort_key is not None:
+        grplst.sort(key=lambda group: sort_key(group[0]))
+
+    for first, compgrp in grplst:
 
         # Get component fields
         fields = _get_fields(first, pat_fields)