Transform: det and normalized. #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VascoSch92
reviewed
Feb 3, 2024
| @@ -88,6 +88,14 @@ def conjugate(self): | |||
| a, b, c, d = self.abcd | |||
| return Transform(a.conjugate(), b.conjugate(), | |||
| c.conjugate(), d.conjugate(), conj=not self.conj) | |||
| def det(self): | |||
There was a problem hiding this comment.
These two could be properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds methods
det()andnormalized()toTransform. These are mostly for convenience. For instance it is hard to tell whether to twoTransforms are the same transformation since they may differ by a complex scalar. Note that the normalized version is not technically normalized as two normalizedTransformsdescribing the same transformation may differ by sign (but only by sign).