Consistent action of conjugation #26
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to Transform.apply_to_tuple() a potential conjugation is first applied before the matrix is multiplied. Since the action is from the left this means that conjugation is on the right. Thus in Transform.merge() conjugation has to be applied to the entries of the product of the factors to the right not to the left. This commit fixes this.
VascoSch92
reviewed
Feb 22, 2024
| @@ -95,13 +95,13 @@ def identity(): | |||
| def merge(*transfoms): | |||
| a,b,c,d = 1,0,0,1 | |||
| conj = False | |||
| for i, trans in enumerate(transfoms): | |||
| for trans in reversed(transfoms): | |||
| a2,b2,c2,d2 = trans.abcd | |||
| if trans.conj: | |||
| a,b,c,d = (a.conjugate(), b.conjugate(), c.conjugate(), | |||
There was a problem hiding this comment.
you don't need the ( and ) here
VascoSch92
reviewed
Feb 22, 2024
| a2,b2,c2,d2 = trans.abcd | ||
| if trans.conj: | ||
| a,b,c,d = (a.conjugate(), b.conjugate(), c.conjugate(), | ||
| d.conjugate()) | ||
| conj = not conj | ||
| a,b,c,d = a*a2+c*b2, b*a2+d*b2, a*c2+c*d2, b*c2+d*d2 | ||
| a,b,c,d = a2*a+b2*c, a2*b+b2*d, c2*a+d2*c, c2*b+d2*d | ||
| return Transform(a,b,c,d,conj=conj) | ||
| @staticmethod |
There was a problem hiding this comment.
leave a space between two methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It should generally be true that
a.apply_to_point(b.apply_to_point(p)) == Transform.merge(a,b).apply_to_point(p)
(up to numerical error).
According to Transform.apply_to_tuple() a potential conjugation is first applied before the matrix is multiplied. Since the action is from the left this means that conjugation is on the right.
Thus in Transform.merge() conjugation has to be applied to the entries of the product of the factors to the right not to the left (see issue #24). This commit fixes this.