Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update from BioKIC 20230814 #6

Merged
merged 9 commits into from
Aug 14, 2023
Merged

update from BioKIC 20230814 #6

merged 9 commits into from
Aug 14, 2023

Conversation

cdtyrrell
Copy link
Owner

Pull Request Checklist:

  • Features and backlog bugs should be merged into the Development branch, NOT master
  • Hotfixes should be merged into both the Development and master branches (at the same time).
  • All new text is preferrably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages)
  • There are no linter errors
  • New features have responsive design (i.e., look aesthetically pleasing both full screen and with small or mobile screens)
  • Symbiota coding standards have been followed
  • If any files have been reformatted (e.g., by an autoformatter), the reformat is its own, separate commit in the PR
  • Comment which GitHub issue(s), if any does this PR address
  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
  • If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place

Thanks for contributing and keeping it clean!

egbot and others added 9 commits June 2, 2023 15:13
- Resolve issue with occurrence-taxon indexing code
- Only build sciname from taxon units if all units are mapped
- Resolve issue with ID Key editor not displaying characters that are not grouped
-Taxon Profile insert issue
Hotfix: Occurrence upload, Key editor, Taxon Profile
* Occurrence Upload adjustment
    - Trim off delimiters that are left on the beginning or end of filter string to ensure that null values are not included
* Collection Listing bug fix
    - Collection categories failing to be persist
* Occurrence Image Submissions issue resolution
    - Set default image sort order to 40 for observations to ensure that preserved specimen images do not take precedence
* Image Processing bug
    - collection identifier (collid) failed to be passed to statistics update function
* Resolve Taxonomy Harvester issues
    - Improve TROPICOS method of matching on infraspecific taxa
    - Improve close match suggestions
* Taxonomy Harvesting minor adjustments

- Check resources before interpretation and again after interpretation
- If name is matched within one recourse, skip the unnecessary step to check other resources
- Synchronize display text

* Refactor ImageLocalProcessor and resolve various bugs

- Provide support for input file to include medium and thumbnail image derivatives
- Expand Image Map processing to allow mapping file to include any images table field name
- Expand images insert function to handle any valid field found within images table
- Merge duplicate actions into shared private functions
- MD5 hash large version of image input file, but don't overwrite hash if supplied by source, unless image is not modified by upload scripts
- Handle BOM characters at start of csv file.
- Trim header elements for testing column names.
- Enforce default action of accepting derivative urls supplied within a csv image map file
- Improve uriExists function
- Make sure to remove staging images

* Occurrence Public Display page

- Allow occurrence archive (deleted occurrences) to be searchable by GUID (occurrenceID, recordID), thus reporting when a record is deleted

* Checklist multi-polygon map Issue

- Multipolygons defined within a checklist fail to map within both simple and dynamic maps

* Suppress geo ref index during stats update

* Occurrence Reviewer bug

- Fix for field name and start and end date filter variables failing to be carried forward when advancing to pages beyond 1000 records
BioKIC#335

* Collection metadata editor bug

- Reset contact array to ensure that JSON string is standardized as a non-associated array
Resolves issue: BioKIC#487

---------

Co-authored-by: Greg Post <[email protected]>
* Hotfix - 2023-07-22
- DwcArchivePublishing: Material Sample  publishing bug
- DwC-A upload: Scientific name failed to be built when taxonomic data is supplied by by individual components 
- Taxonomic autocomplete: Allow autocomplete handle apostrophes
- Checklist Display: Bug fix that interfered with display of linked voucher images
- Checklist Manager: Checklist taxon search autocomplete failed to include higher taxa (parent data)
- Taxonomy Harvester bug: F-dex harvest failed to grab parents when source was not "Index Fungorum"
- Specimen Upload: Set version data changes as the default action only when a collection is live managed
- Occurrence Search Harvest: Reworked search form validation to be more efficient; Fix bug with occurrence attribute checkbox/radio failing to be recognized as a selected component

* Hotfix 2023-06-19 (BioKIC#518)
- Taxonomy Harvesting: Don't check following taxonomic resource on a positive match and input; synchronize display text
- Refactor ImageLocalProcessor: 
-- Provide support for input file to include medium and thumbnail image derivatives
-- Expand Image Map processing to allow mapping file to include any images table field name
-- Expand images insert function to handle any valid field found within images table
-- MD5 hash large version of image input file, but don't overwrite hash if supplied by source
-- Handle BOM characters at start of csv file.
-- Trim header elements for testing column names.
-- Enforce default action of accepting derivative urls supplied within a csv image map file
-- Make sure to remove staging images
- Occurrence Public Display: Allow occurrence archive (deleted occurrences) to be searchable by GUID (occurrenceID, recordID), thus reporting when a record is deleted
- Checklist multi-polygon Map: resolve Multipolygons failing to map within both simple and dynamic maps
- Occurrence Reviewer: Fix for field name and start and end date filter variables failing to be carried forward when advancing to pages beyond 1000 records
- Collection metadata editor: Reset contact array to ensure that JSON string is standardized as a non-associated array

---------

Co-authored-by: Greg Post <[email protected]>
hotfix 2023-07-31

* Glossary issues
- Allow terms search to do a double wildcard search to expand functionality and resolve issue with zero return when html tags (e.g. italic) are included with the terms
- Remove restrictions and unnecessary default actions associated with unset language and taxon terms so that thesaurus better functions as a single language glossaries
- Fix various issues with export of report when there is a single language glossary and/or terms are not linked to specific taxa
- Fix issue report export not including full list when terms have complex language relationships
- Improve file naming and content/layout of Word report export
- Resolve issues with inclusion of all Spanish language translation files
- Include translations for some missed terms

* Occurrence editor
- Fix bug with year, month, day field failing to null when eventDate is nulled out
- allow tidInterpreted value to be transferred when scientific name is added to form via duplicate tool

* Occurrence Search 
- Fix issue with autocomplete failing to return names that contain single or double quotes
- Fix issue taxon name search failing to return correct data when name contains single or double quotes
- Map Search: resolved issue where map recenters in the middle of the ocean when a search returns no coordinates

* Taxonomy issues and bugs
- Taxonomy Utilities: Fix issue interfering import of taxa with hybrid symbol when there is not a space between symbol and name units
- Taxonomy Harvesting: Resolve 'Unranked" taxonRank designations when taxon is a non-accepted genus
- Taxonomy Upload: Minor adjustments needed to support processing of taxa immediately adjacent to kingdom rank
* Occurrence Search bug
- Resolve issue with sanitation of occurrence search variables held within session storage
@cdtyrrell cdtyrrell merged commit 35d36c2 into tyrrell-dev Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants