fix: plan changes (#175)

* fix: re-running pre-commit to generate changes * fix: issues from last pr Use string interpolation, add mocking for conftest-checks to tests. * chore: autofmt * fix: adding back in blank line
cds-snc · Mar 21, 2023 · 26fbdfe · 26fbdfe
1 parent afeda91
commit 26fbdfe
Show file tree

Hide file tree

Showing 7 changed files with 21 additions and 6 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/action.js b/src/action.js
@@ -77,7 +77,7 @@ const action = async () => {
     {
       key: "conftest",
       depends: "show-json-out",
-      exec: "conftest test plan.json --no-color --update ${conftestChecks}",
+      exec: `conftest test plan.json --no-color --update ${conftestChecks}`,
       output: true,
     },
   ];

diff --git a/src/github.js b/src/github.js
@@ -9,6 +9,7 @@ const commentTemplate = `## {{ title }}
 **{{ "✅" if results.plan.isSuccess else "❌" }} &nbsp; Terraform Plan:** \`{{ "success" if results.plan.isSuccess else "failed" }}\`
 {% if not skipConftest -%}
 **{{ "✅" if results.conftest.isSuccess else "❌" }} &nbsp; Conftest:** \`{{ "success" if results.conftest.isSuccess else "failed" }}\` 
+
 {% endif -%}
 {% endif -%}
 {% if not results.init.isSuccess -%}

diff --git a/src/policy/policy.js b/src/policy/policy.js
diff --git a/src/policy/policy.wasm b/src/policy/policy.wasm
diff --git a/test/action.test.js b/test/action.test.js
@@ -32,6 +32,11 @@ describe("action", () => {
   test("default flow", async () => {
     execCommand.mockReturnValue({ isSuccess: true, output: "{}" });
     when(core.getInput).calledWith("directory").mockReturnValue("foo");
+    when(core.getInput)
+      .calledWith("conftest-checks")
+      .mockReturnValue(
+        "git::https://github.com/cds-snc/opa_checks.git//aws_terraform"
+      );
     when(core.getMultilineInput)
       .calledWith("terraform-init")
       .mockReturnValue([
@@ -114,6 +119,11 @@ describe("action", () => {
   test("terragrunt flow", async () => {
     execCommand.mockReturnValue({ isSuccess: true, output: "{}" });
     when(core.getInput).calledWith("directory").mockReturnValue("bar");
+    when(core.getInput)
+      .calledWith("conftest-checks")
+      .mockReturnValue(
+        "git::https://github.com/cds-snc/opa_checks.git//aws_terraform"
+      );
     when(core.getBooleanInput).calledWith("terragrunt").mockReturnValue(true);
 
     await action();
@@ -254,7 +264,11 @@ describe("action", () => {
   test("failed command", async () => {
     execCommand.mockReturnValue({ isSuccess: false, output: "" });
     when(core.getInput).calledWith("directory").mockReturnValue("foo");
-
+    when(core.getInput)
+      .calledWith("conftest-checks")
+      .mockReturnValue(
+        "git::https://github.com/cds-snc/opa_checks.git//aws_terraform"
+      );
     await action();
 
     expect(core.setFailed.mock.calls.length).toBe(1);