fix healpix order corresponding to 1 pixel on the image calculation in from_fits_image #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmatthieu3
force-pushed
the
fix-from-fits-image-mask
branch
from
d6cf645 to
d6c6557
Compare
|
I made the test pass and from_fits_image also return a moc at the "good" pixel order for file: coadd_2exps_LANCZSOS3_noBkgSub_AL_block100.fits.gz |
ManonMarchand
force-pushed
the
fix-from-fits-image-mask
branch
from
d6c6557 to
bce8e5a
Compare
ManonMarchand
force-pushed
the
fix-from-fits-image-mask
branch
2 times, most recently
from
3790292 to
19765a7
Compare
fix: return an empty MOC when no image data was found
ManonMarchand
force-pushed
the
fix-from-fits-image-mask
branch
from
19765a7 to
8851681
Compare
|
(just rebased on master, there was a conflict in the changelog) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix to determine correctly the deepest healpix order containing at least one pixel of the image.
I updated the from_image_from_fits notebook to add a call to a new file that was not working before (pixel order computed was too shallow).
I link the issue #167 which is more about an api question.