Skip to content

Commit

Permalink
Merge pull request containers#11137 from edsantiago/helpfulerer
Browse files Browse the repository at this point in the history
[CI:DOCS] tests-expect-exit: include source line numbers
  • Loading branch information
openshift-ci[bot] authored Aug 6, 2021
2 parents 9853b14 + c9e2f2f commit 04ab2b1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ tests-included:

.PHONY: tests-expect-exit
tests-expect-exit:
@if egrep 'Expect.*ExitCode' test/e2e/*.go | egrep -v ', ".*"\)'; then \
@if egrep --line-number 'Expect.*ExitCode' test/e2e/*.go | egrep -v ', ".*"\)'; then \
echo "^^^ Unhelpful use of Expect(ExitCode())"; \
echo " Please use '.Should(Exit(...))' pattern instead."; \
echo " If that's not possible, please add an annotation (description) to your assertion:"; \
Expand Down

0 comments on commit 04ab2b1

Please sign in to comment.