forked from Shopify/shopify-api-ruby
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix CustomerAddress.all returning no results
Previously, when fetching `all` on CustomerAddress it would return an empty array. Two issues (Shopify#970, Shopify#1018) were opened outlining the problem. Initial attempt was to override `json_response_body_name` which worked for fetching arrays of results. It doesn't work for fetching individual results though. I wound up overriding `create_instances_from_response` for CustomerAddress. It isn't ideal but it does seem to behave correctly. Assertions have been added to the the tests as well.
- Loading branch information
Showing
2 changed files
with
35 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters