Skip to content

Commit

Permalink
Reverting python changes and removing Java unit tests. Documentation …
Browse files Browse the repository at this point in the history
  • Loading branch information
leandrodamascena committed Jan 9, 2021
1 parent d7979a9 commit 2ba0b66
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 44 deletions.
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,4 +32,4 @@ Contribution Steps:
4. Open up a pr

## Converting Lambda Fns to CDK Language
This would be a big help and is a great way to get started contributing. When a pattern launches typically I build it in TypeScript and then port it over to Python. In order to reduce bugs at launch I typically reuse the JS Lambdda Fn in the Python version then slowly refactor over time to full Python. If you spot one of these JS functions in a Python pattern and want to convert it to Python it is small enough that you could just do it and open a Pull Request
This would be a big help and is a great way to get started contributing. When a pattern launches typically I build it in TypeScript and then port it over to Python. In order to reduce bugs at launch I typically reuse the JS Lambda Fn in the Python version then slowly refactor over time to full Python. If you spot one of these JS functions in a Python pattern and want to convert it to Python it is small enough that you could just do it and open a Pull Request

This file was deleted.

2 changes: 1 addition & 1 deletion the-scalable-webhook/python/setup.py
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import setuptools


with open("README.md", encoding="UTF-8") as fp:
with open("README.md") as fp:
long_description = fp.read()


Expand Down

0 comments on commit 2ba0b66

Please sign in to comment.