feat: add a subset of properties for stackset stack manipulation #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arrjay
changed the title
corymhall
suggested changes
May 24, 2023
| @@ -49,9 +75,10 @@ export class StackSetStack extends Stack { | |||
| public readonly templateFile: string; | |||
| private _templateUrl?: string; | |||
| private _parentStack: Stack; | |||
| constructor(scope: Construct, id: string) { | |||
| constructor(scope: Construct, id: string, props: StackSetStackProps) { | |||
There was a problem hiding this comment.
Suggested change
| constructor(scope: Construct, id: string, props: StackSetStackProps) { | |
| constructor(scope: Construct, id: string, props: StackSetStackProps = {}) { |
Sorry 1 more. Since all the props are optional this should be optional as well.
|
+1 for this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #116
the current implementation of this provides some known properties that are ok to pass along, rather than everything except the
synthesizerproperty.