chore(docs): minor doc cleanup #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echeung-amzn
force-pushed
the
re-dashboards
branch
from
4ec580d to
a4a8bb5
Compare
cayman-amzn
approved these changes
Mar 30, 2023
Comment on lines
-59
to
-63
| <details><summary><strong>Golang</strong></summary> | ||
|
|
||
| Coming soon! | ||
| </details> | ||
|
|
There was a problem hiding this comment.
No longer coming soon?
There was a problem hiding this comment.
It hasn't been a priority so I don't want to mislead people. There's an open issue for it though: #21
| @@ -6,7 +6,9 @@ import { MetricFactory } from "../metric"; | |||
| import { AwsConsoleUrlFactory } from "../url"; | |||
|
|
|||
| /** | |||
| * A scope (construct) where all monitoring constructs are living in. | |||
| * A scope where all the monitoring of constructs is managed (alarms, dashboards, etc.). | |||
There was a problem hiding this comment.
Suggested change
| * A scope where all the monitoring of constructs is managed (alarms, dashboards, etc.). | |
| * A scope where all monitored constructs are managed from (ie. alarms, dashboards, etc.). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #343
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license