Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add some additional shell logging #272

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

HBobertz
Copy link
Contributor

@HBobertz HBobertz commented Dec 30, 2024

Adding some additional tests, so I can verify #221 isn't causing any breaking changes

These are LLM generated btw

@HBobertz HBobertz marked this pull request as ready for review December 30, 2024 15:22
HBobertz and others added 2 commits December 30, 2024 10:34
Copy link

@kaizencc kaizencc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing i don't love about LLM generation is that the tests can work but be very different from how existing tests look in the code. I wonder if you can somehow tell the LLM to follow the conventions of existing tests when generating new ones. This isn't just styling btw, it decreases the maintainability of the project to have multiple ways to do the same thing in our tests (this is true for human written code too, and happens all the time, so its not unique to LLMs).

i'm not going to take the time to figure out if that's the case for this PR -- its just something to think about in the future.

@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Dec 30, 2024
Merged via the queue into main with commit b3c1e4f Dec 30, 2024
8 checks passed
@aws-cdk-automation aws-cdk-automation deleted the bobertzh/shell-logging-test branch December 30, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants