This repository was archived by the owner on Mar 3, 2025. It is now read-only.
fix: upload to Object Lock-enabled bucket fails #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We thought disabling a content checksum for S3 clients would work in all scenarios, so that we can use the same S3 client config for FIPS and non-FIPS environments. Turns out that yet another scenario requires content checksums: PutObject to an Object Lock-enabled S3 bucket. Again, there's no way to make this work with SDKv2. We do the best we can do: turn off MD5 signing only for FIPS environments. Result: it will not be possible to use Object Lock in FIPS environments. But at least we unbreak the scenario for non-FIPS customers. Relates to aws/aws-cdk#31926
mrgrain
approved these changes
Oct 30, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 30, 2024
We thought disabling a content checksum for S3 clients would work in all scenarios, so that we can use the same S3 client config for FIPS and non-FIPS environments. Turns out that yet another scenario requires content checksums: PutObject to an Object Lock-enabled S3 bucket. Again, there's no way to make this work with SDKv2. We do the best we can do: turn off MD5 signing only for FIPS environments. Result: it will not be possible to use Object Lock in FIPS environments. But at least we unbreak the scenario for non-FIPS customers. Relates to aws/aws-cdk#31926
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We thought disabling a content checksum for S3 clients would work in all scenarios, so that we can use the same S3 client config for FIPS and non-FIPS environments. Turns out that yet another scenario requires content checksums: PutObject to an Object Lock-enabled S3 bucket.
Again, there's no way to make this work with SDKv2. We do the best we can do: turn off MD5 signing only for FIPS environments. Result: it will not be possible to use Object Lock in FIPS environments.
But at least we unbreak the scenario for non-FIPS customers.
Relates to aws/aws-cdk#31926