Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deployment): Added Classname to ExposeDeploymentViaIngressOptions #5234

Open
wants to merge 1 commit into
base: k8s-31/main
Choose a base branch
from

Conversation

yashisrani
Copy link

Fixes #2178

Description

  • Enhance the exposeViaIngress("/") method by allowing the className option to be set directly.
  • This will improve consistency between constructors and exposeXXX methods while making the code more concise and meaningful.

Proposed Solution

  • Modify the exposeViaIngress() method to accept a className option:
deployment.exposeViaIngress("/", { className: "nginx" });

@yashisrani yashisrani changed the title Added Classname to ExposeDeploymentViaIngressOptions feat: Added Classname to ExposeDeploymentViaIngressOptions Jan 30, 2025
@yashisrani yashisrani changed the title feat: Added Classname to ExposeDeploymentViaIngressOptions feat(deployment): Added Classname to ExposeDeploymentViaIngressOptions Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant