fix: app outdir property cannot be different from CLI or cdk8s.yaml file (#783)
#786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… file (#783) Currently setting the `outdir` property for CDK8s app throws an error, ``` ERROR: synthesis failed, app expected to create "dist" ``` This is due to the CLI not able to recognize this change in the `outdir` in the application property. The value specified in the `outdir` needs to be similar to what is mentioned either in CLI's `--output` argument or the `output` property in the cdk8s.yaml file. Signed-off-by: Vinayak Kukreja <[email protected]> Resolves cdk8s-team/cdk8s-cli#210 (cherry picked from commit 05bf5f4) Signed-off-by: Vinayak Kukreja <[email protected]>
cdk8s-automation
added
the
auto-approve
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
⚪ Backport skippedThe pull request was not backported as there were no branches to backport to. If this is a mistake, please apply the desired version labels or run the backport tool manually. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
2.xto1.x:outdirproperty cannot be different from CLI or cdk8s.yaml file (#783)Questions ?
Please refer to the Backport tool documentation