Skip to content

Commit

Permalink
fix: app outdir property cannot be different from CLI or cdk8s.yaml…
Browse files Browse the repository at this point in the history
… file (#783) (#786)

# Backport

This will backport the following commits from `2.x` to `1.x`:
 - [fix: app `outdir` property cannot be different from CLI or cdk8s.yaml file (#783)](#783)



### Questions ?
Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
  • Loading branch information
cdk8s-automation authored Oct 4, 2022
1 parent 4a076c3 commit f1fbb0a
Show file tree
Hide file tree
Showing 4 changed files with 56 additions and 0 deletions.
16 changes: 16 additions & 0 deletions docs/java.md
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,14 @@ App.Builder.create()

The directory to output Kubernetes manifests.

If you synthesize your application using `cdk8s synth`, you must
also pass this value to the CLI using the `--output` option or
the `output` property in the `cdk8s.yaml` configuration file.
Otherwise, the CLI will not know about the output directory,
and synthesis will fail.

This property is intended for internal and testing use.

---

##### `outputFileExtension`<sup>Optional</sup> <a name="org.cdk8s.AppProps.parameter.outputFileExtension"></a>
Expand Down Expand Up @@ -844,6 +852,14 @@ public java.lang.String getOutdir();

The directory to output Kubernetes manifests.

If you synthesize your application using `cdk8s synth`, you must
also pass this value to the CLI using the `--output` option or
the `output` property in the `cdk8s.yaml` configuration file.
Otherwise, the CLI will not know about the output directory,
and synthesis will fail.

This property is intended for internal and testing use.

---

##### `outputFileExtension`<sup>Optional</sup> <a name="org.cdk8s.AppProps.property.outputFileExtension"></a>
Expand Down
24 changes: 24 additions & 0 deletions docs/python.md
Original file line number Diff line number Diff line change
Expand Up @@ -225,6 +225,14 @@ cdk8s.App(

The directory to output Kubernetes manifests.

If you synthesize your application using `cdk8s synth`, you must
also pass this value to the CLI using the `--output` option or
the `output` property in the `cdk8s.yaml` configuration file.
Otherwise, the CLI will not know about the output directory,
and synthesis will fail.

This property is intended for internal and testing use.

---

##### `output_file_extension`<sup>Optional</sup> <a name="cdk8s.AppProps.parameter.output_file_extension"></a>
Expand Down Expand Up @@ -866,6 +874,14 @@ outdir: str

The directory to output Kubernetes manifests.

If you synthesize your application using `cdk8s synth`, you must
also pass this value to the CLI using the `--output` option or
the `output` property in the `cdk8s.yaml` configuration file.
Otherwise, the CLI will not know about the output directory,
and synthesis will fail.

This property is intended for internal and testing use.

---

##### `output_file_extension`<sup>Optional</sup> <a name="cdk8s.AppProps.property.output_file_extension"></a>
Expand Down Expand Up @@ -2854,6 +2870,14 @@ cdk8s.Testing.app(

The directory to output Kubernetes manifests.

If you synthesize your application using `cdk8s synth`, you must
also pass this value to the CLI using the `--output` option or
the `output` property in the `cdk8s.yaml` configuration file.
Otherwise, the CLI will not know about the output directory,
and synthesis will fail.

This property is intended for internal and testing use.

---

###### `output_file_extension`<sup>Optional</sup> <a name="cdk8s.AppProps.parameter.output_file_extension"></a>
Expand Down
8 changes: 8 additions & 0 deletions docs/typescript.md
Original file line number Diff line number Diff line change
Expand Up @@ -702,6 +702,14 @@ public readonly outdir: string;

The directory to output Kubernetes manifests.

If you synthesize your application using `cdk8s synth`, you must
also pass this value to the CLI using the `--output` option or
the `output` property in the `cdk8s.yaml` configuration file.
Otherwise, the CLI will not know about the output directory,
and synthesis will fail.

This property is intended for internal and testing use.

---

##### `outputFileExtension`<sup>Optional</sup> <a name="cdk8s.AppProps.property.outputFileExtension"></a>
Expand Down
8 changes: 8 additions & 0 deletions src/app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,14 @@ export interface AppProps {
/**
* The directory to output Kubernetes manifests.
*
* If you synthesize your application using `cdk8s synth`, you must
* also pass this value to the CLI using the `--output` option or
* the `output` property in the `cdk8s.yaml` configuration file.
* Otherwise, the CLI will not know about the output directory,
* and synthesis will fail.
*
* This property is intended for internal and testing use.
*
* @default - CDK8S_OUTDIR if defined, otherwise "dist"
*/
readonly outdir?: string;
Expand Down

0 comments on commit f1fbb0a

Please sign in to comment.