fix: app outdir property cannot be different from CLI or cdk8s.yaml file
#783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s.yaml file Signed-off-by: Vinayak Kukreja <[email protected]>
Signed-off-by: github-actions <[email protected]>
iliapolo
changed the title
outdir property cannot be different from CLI or cdk8s.yaml fileoutdir property cannot be different from CLI or cdk8s.yaml file
iliapolo
requested changes
Oct 3, 2022
src/app.ts
Outdated
Comment on lines
26
to
32
| * By default, the value you pass to the CDK8s CLI's `--output` flag | ||
| * or in the `output` property of cdk8s.yaml file will be used, | ||
| * and if you change it to a different directory the CLI will fail | ||
| * to pick up the new output directory. | ||
| * | ||
| * This property is intended for internal and testing use. | ||
| * |
There was a problem hiding this comment.
Where not focusing on the default behavior, but rather on the conflicts that may arise.
Suggested change
| * By default, the value you pass to the CDK8s CLI's `--output` flag | |
| * or in the `output` property of cdk8s.yaml file will be used, | |
| * and if you change it to a different directory the CLI will fail | |
| * to pick up the new output directory. | |
| * | |
| * This property is intended for internal and testing use. | |
| * | |
| * If you synthesize your application using `cdk8s synth`, you must also pass this value to the CLI using the `-- | |
| * output` option or the `output` property in the `cdk8s.yaml` configuration file. | |
| * Otherwise, the CLI will not know about the output directory, and synthesis will fail. | |
| * | |
| * This property is intended for internal and testing use. | |
| * |
There was a problem hiding this comment.
I see, ok, will make this update.
Signed-off-by: Vinayak Kukreja <[email protected]>
Signed-off-by: github-actions <[email protected]>
iliapolo
approved these changes
Oct 4, 2022
cdk8s-automation
pushed a commit
that referenced
this pull request
Oct 4, 2022
… file (#783) Currently setting the `outdir` property for CDK8s app throws an error, ``` ERROR: synthesis failed, app expected to create "dist" ``` This is due to the CLI not able to recognize this change in the `outdir` in the application property. The value specified in the `outdir` needs to be similar to what is mentioned either in CLI's `--output` argument or the `output` property in the cdk8s.yaml file. Signed-off-by: Vinayak Kukreja <[email protected]> Resolves cdk8s-team/cdk8s-cli#210 (cherry picked from commit 05bf5f4) Signed-off-by: Vinayak Kukreja <[email protected]>
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mergify bot
pushed a commit
that referenced
this pull request
Oct 4, 2022
… file (#783) (#786) # Backport This will backport the following commits from `2.x` to `1.x`: - [fix: app `outdir` property cannot be different from CLI or cdk8s.yaml file (#783)](#783) ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently setting the
outdirproperty for CDK8s app throws an error,This is due to the CLI not able to recognize this change in the
outdirin the application property.The value specified in the
outdirneeds to be similar to what is mentioned either in CLI's--outputargument or theoutputproperty in the cdk8s.yaml file.Signed-off-by: Vinayak Kukreja [email protected]
Resolves cdk8s-team/cdk8s-cli#210